Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-3243: support pickle & deepcopy #3245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

helpmefindaname
Copy link
Collaborator

Closes gh-3243

A suggestion how we could support pickle and deepcopy without having to create multiple spans etc.

The idea is to use __getitem__ to create spans and relations by indexing: sentence[0:5] to create a span, sentence[span_a, span_b] to create a relation.

Downside would be, that those who still instantiate Span or Relation manually, would receive unexpected results.

@dobbersc @alanakbik what do you think?

@helpmefindaname helpmefindaname force-pushed the gh-3243/add_pickle_support branch 2 times, most recently from d64195e to 22cd5c3 Compare August 8, 2023 12:50
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 17, 2024
@stale stale bot removed the wontfix This will not be worked on label Mar 29, 2024
@helpmefindaname helpmefindaname marked this pull request as ready for review August 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support pickle and copy.deepcopy for Sentences
1 participant